Add missing methods to TypeScript definitions #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 3.25 MB ℹ️ View Unchanged
|
Merged
sreuland
reviewed
Aug 23, 2024
| @@ -1058,7 +1059,9 @@ export class TransactionBuilder { | |||
| options?: TransactionBuilder.TransactionBuilderOptions | |||
| ); | |||
| addOperation(operation: xdr.Operation): this; | |||
| addOperationAt(op: xdr.Operation, i: number): this; | |||
There was a problem hiding this comment.
is it getting to point where it's worthwhile to add ts tests, index.d.test.ts? how do we know addOperation will work when used by a client, or is there some base validation done in build pipeline?
There was a problem hiding this comment.
There's JS unit tests for it but you're right that we should generally add more to the types/test.ts file. Unfortunately said tests only fail when you, well, add to them, and if you're adding to them then you're adding to the index.d.ts file anyway, so it wouldn't have prevented this slip-up (which came from an external contributor anyway).
There was a problem hiding this comment.
Added the typing tests in c5c5f9b!
sreuland
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explanatory, see diff.