Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow arguments and options to be passed through to workflow scripts #24

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Allow arguments and options to be passed through to workflow scripts #24

merged 3 commits into from
Sep 9, 2024

Conversation

defunctl
Copy link
Contributor

@defunctl defunctl commented Sep 9, 2024 •
edited
Loading

Main Changes

Allow arguments and options to be passed through to underlying workflow commands, e.g.

composer -- pup workflow set-version -- arg1 arg2 otherArg --option-one=test1 --option-two=test2

image

@defunctl defunctl self-assigned this Sep 9, 2024
borkweb
borkweb requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@borkweb borkweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great. Some tests would be nice for this - I can do those if you don't have space.

@defunctl defunctl merged commit fc79b6b into main Sep 9, 2024
2 checks passed
@defunctl defunctl deleted the feature/allow-arguments-to-be-passed-to-workflows branch September 9, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkweb borkweb borkweb approved these changes

Assignees

@defunctl defunctl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@defunctl @borkweb