Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.4.4 #168

Merged
merged 8 commits into from
Aug 15, 2023
Merged

Version 1.4.4 #168

merged 8 commits into from
Aug 15, 2023

Conversation

lucatume
Copy link
Contributor

@lucatume lucatume commented Aug 15, 2023

This PR is born to mitigate the issue where some plugins, like ET+, would require version 6.2+ of WordPress.
The version, fixed in the Dockerfile, cannot be updated in CI and must be shipped with the image.

This PR updates the code to build the wordpress image to:

  • build based on 6.2 for PHP 8.0+
  • build based on 6.1.1 for PHP 7.4 as there is no official WordPress image for PHP 7.4 and WordPress 6.2+; the containers/wordpress/Dockerfile will detect PHP version 7.4 and will update WordPress, in the source directory it's pulled from, to version 6.2.

This system can be used to handle other future incompatibilities.

remove PHP 8.2 fix as no longer required
@lucatume lucatume self-assigned this Aug 15, 2023
When starting the wordpress container, the bound wordpress directory would be found empty and the
/usr/src/wordpress content, version 6.1.1, would be copied over it.
@lucatume lucatume requested a review from borkweb August 15, 2023 13:07
Copy link
Member

@borkweb borkweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locking in and updating in the Dockerfile - clever! Approved 👍

@lucatume lucatume merged commit 7bdc058 into main Aug 15, 2023
10 checks passed
@lucatume lucatume deleted the 1.4.4 branch August 15, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants