Move notices script inline #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the notices scripts inline.
Issue before
The issue we face with the current iteration is that the script is run multiple times if multiple uplink-based plugins exist. This means the notices were added to plugins multiple times.
Note that it also required some changes before it'd work as some of the updated vars are incorrect.
Solution
This PR moves the script inline, as we can't accurately get the plugin slug from within an external JS file. It also means the script only runs once per plugin.
This also prevents versioning issues if a plugin is using an older version of the same script. Now each plugin uses their own independent version of the script.
Related to #24