chore: Add testDescription helper and update error processing #1
Conversation
Signed-off-by: asararatnakar <[email protected]>
asararatnakar
changed the title
Signed-off-by: asararatnakar <[email protected]>
| // Match stepzen AWS 60 second timeout. | ||
| const defaultTimeout = 60000 | ||
|
|
||
| function testDescription(testRoot, fullDirName) { |
There was a problem hiding this comment.
I'm not yet convinced this is suitable for a generic test harness, seems clearer and more typical just to have constants for describe / it.
Maybe move to a separate PR.
| // (3) not implemented - root value with field errors: {data: {customer: {name: "Fred" email:null}}, "errors":[...]} | ||
| // (4) not implemented - root value with request errors: {"errors":[...]} | ||
| // (3) root value with field errors: {data: {customer: {name: "Fred" email:null}}, "errors":[...]} | ||
| // or request errors: {"errors":[...]} |
There was a problem hiding this comment.
Responses with request errors are different to responses with field errors, which is why they were separated. Please keep the separation.
| if (Object.hasOwn(expected, "errors")) { | ||
| chai.expect.fail("field errors in response not yet supported.") | ||
| } | ||
| if (Object.hasOwn(expected, "data") || Object.hasOwn(expected, "errors")) { |
There was a problem hiding this comment.
Just 2,3 means it's data && errors.
| if (Object.hasOwn(expected, "errors")) { | ||
| chai.expect.fail("field errors in response not yet supported.") | ||
| } | ||
| if (Object.hasOwn(expected, "data") || Object.hasOwn(expected, "errors")) { | ||
| chai.expect(response.body).to.deep.equal(expected); |
There was a problem hiding this comment.
Generically this will not work for expected with errors, which is why it needs to be separated.
This is because the order of errors cannot be guaranteed. Expected field errors need to be explicitly tested that a matching error with the expected path exists. Thus need to test that data matches and then process expected errors.
| // defaultTimeout can be used in describe.timeout() | ||
| // for requests against a graphql endpoint. | ||
| // Match stepzen AWS 60 second timeout. | ||
| const defaultTimeout = 60000 |
There was a problem hiding this comment.
Probably ok for now, but gqltest was trying to stay GraphQL neutral (hence stepzen.js). They may need to be some thought on how to handle default timeouts nicely.
Signed-off-by: asararatnakar [email protected]