Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the barchart show term2 value in list samples if there is overlay #2364

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

airenzp
Copy link
Collaborator

@airenzp airenzp commented Nov 11, 2024

Description

Show term2 value in list samples if there is overlay

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: added and/or passed unit and integration tests, or N/A
  • Todos: commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

@karishma-gangwani
Copy link
Contributor

Thanks for the fix @airenzp. If the term is a numeric term then the value needs to be shown in the second column regardless of t1 or t2. because term 1 can be numeric while overlay could be categorical. maybe we can show both the columns for term 1 and term 2 when 'list samples' is clicked?

creilly8
creilly8 previously approved these changes Nov 12, 2024
Copy link
Contributor

@creilly8 creilly8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks.

@karishma-gangwani
Copy link
Contributor

Thanks @airenzp. I see an error in ash ds:

in term 1 add 'tp53' from mutation tab and term2 'age at diagnosis' from dictionary variables. client side shows an error when samples are listed from the 'list samples' option for any of the groups. can you replicate and see if that's real? This might need to expand to other term types.

image

@airenzp
Copy link
Collaborator Author

airenzp commented Nov 12, 2024

Thanks @airenzp. I see an error in ash ds:

in term 1 add 'tp53' from mutation tab and term2 'age at diagnosis' from dictionary variables. client side shows an error when samples are listed from the 'list samples' option for any of the groups. can you replicate and see if that's real? This might need to expand to other term types.

image

Should be fixed now

Copy link
Contributor

@karishma-gangwani karishma-gangwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes @airenzp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants