-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the barchart show term2 value in list samples if there is overlay #2364
base: master
Are you sure you want to change the base?
Conversation
Thanks for the fix @airenzp. If the term is a numeric term then the value needs to be shown in the second column regardless of t1 or t2. because term 1 can be numeric while overlay could be categorical. maybe we can show both the columns for term 1 and term 2 when 'list samples' is clicked? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thanks.
Thanks @airenzp. I see an error in ash ds: in term 1 add 'tp53' from mutation tab and term2 'age at diagnosis' from dictionary variables. client side shows an error when samples are listed from the 'list samples' option for any of the groups. can you replicate and see if that's real? This might need to expand to other term types. |
Should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fixes @airenzp
Description
Show term2 value in list samples if there is overlay
Checklist
Check each task that has been performed or verified to be not applicable.