Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated setuptools with adslib in wheel distribution and pyproject.toml #426

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

RobertoRoos
Copy link
Contributor

@RobertoRoos RobertoRoos commented Sep 23, 2024

I think this is pretty close to what I had in mind. This would resolved #425 .
I based this on top of a developing brach I had to switch over to pyproject.toml, so the diff is quite big.

Check the pipelines running on my fork to see what the distributions would look like.

And this PR will likely conflict with #412 and maybe with #399 .

@RobertoRoos RobertoRoos force-pushed the feature/new-setuptools branch 4 times, most recently from 76b71fe to 131d655 Compare September 23, 2024 08:01
@coveralls
Copy link

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 11027487472

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.1%) to 93.816%

Totals Coverage Status
Change from base Build 10633721828: -1.1%
Covered Lines: 6918
Relevant Lines: 7374

💛 - Coveralls

@RobertoRoos
Copy link
Contributor Author

RobertoRoos commented Sep 23, 2024

Hm, I just realized a pretty bug limitation: when installing in editable mode (pip install -e .) adslib isn't compiled and so the package is not usable. That needs to be fixed.

EDIT: Okay, solved. By moving the compiled adslib.so into src/ it will be available under the PATH even in editable mode.

See a test of the distribution wheels in: https://github.com/RobertoRoos/pyads/actions/runs/11010369726

@RobertoRoos RobertoRoos force-pushed the feature/new-setuptools branch 2 times, most recently from 42a06cd to d944b8c Compare September 24, 2024 08:50
@RobertoRoos RobertoRoos marked this pull request as ready for review September 25, 2024 06:25
@RobertoRoos
Copy link
Contributor Author

RobertoRoos commented Sep 25, 2024

Okay, I think I'm happy with this now.
Though we should want to change the CI some, currently it's more to show the distribution works, but this is not needed for every build in the future.

@chrisbeardy
Copy link
Collaborator

Thanks @RobertoRoos , the idea of moving towards pyproject toml is very good and something that felt daunting to do so I'm glad someone managed it!. I will review these changes when I get back from vacation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better distribution of pyads through platformed wheels
4 participants