Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

WIP File Tree API #11

Closed
wants to merge 3 commits into from
Closed

WIP File Tree API #11

wants to merge 3 commits into from

Conversation

kaloyan-raev
Copy link
Collaborator

Fixes #10

@TopperDEL
Copy link

It is working so far!

But I would still propose to return a generic "Content"-object - that Can be either a file or a Folder. Havin a file-object with the property "isDirectory" feels wrong. But that is just my opinion and not a big deal.

What I also would suggest is to put the methods "getChildren" into another helper-object to seperate that logic from the base-storj-functions. So if we introduce a Kind of "StorjExtended"-class or "StorjDirectoryHelper" it would make it more clear what happens here. On constructing such an object, you could take the original storj-object as Parameter so you Can call the base-functions.
Can you follow me? I'm Feeling like I cannot express myself currently. :)

But for the Moment, this helps me alot developing my next-project, the StorjFS filesystem. :) Thank you!

@kaloyan-raev
Copy link
Collaborator Author

One of the options I considered was indeed a higher level API that calls the current low level API. It's good that you share the same thoughts, so I will explore this direction in my next iteration today.

@TopperDEL
Copy link

TopperDEL commented Mar 29, 2018

High Level API and Low Level API - These were the words I was missing yesterday. :)

Yes, I would suggest that, too.

@kaloyan-raev
Copy link
Collaborator Author

I've pushed the reworked API. Look at the FileTreeExample for usage.

@TopperDEL
Copy link

Looks good! Will have a deeper look at it - but might not happen before easter. But the coding and structures Looks good. Thank you for your effort and help!

Copy link

@TopperDEL TopperDEL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both constructors of class Dir Need to be public - otherwise I cannot wrap them correctly.

@TopperDEL
Copy link

I'm fine with that coding - I don't Need the Dir-constructor to be Public anymore.

@TopperDEL
Copy link

We Need to buffer the entries, though. Maybe if you just load the bucket-Contents once until a Change-Operation is performed?

@TopperDEL
Copy link

Seems I found an error - but I'm not completely sure (it's late and I'm tired :) ).

I have a bucket called "Filezilla2" with the following Content (exemplary):
"Filezilla2\Richtfest\Norah Jones\Come Away With Me\Painter Song.mp3"

If I move from Filezilla2 to Richtfest and should get the conent "Norah Jones" - I get "Norah Jones\Come Away With Me" instead. So your logic seems to jump over one Directory-depth. Maybe you can reproduce that.

@RichardLitt
Copy link
Contributor

👋 Hey! Thanks for this contribution. Apologies for the delay in responding!

We've decided to rearchitect Storj, so that we can scale better. You can read more about this decision here. This means that we are entirely focused on v3 at the moment, in the storj/storj repository. Our white paper for v3 is coming very, very soon - follow along on the blog and in our Rocketchat.

As this repository is part of the v2 network, we're no longer maintaining this repository. I am going to close this for now. If you have any questions, I encourage you to jump on Rocketchat and ask them there. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants