make ca bundle a settable value (#24)

* make ca bundle a settable value * bump chart version
strangiato · Apr 1, 2024 · b3465c5 · b3465c5
1 parent 9242bc6
commit b3465c5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/charts/mlflow-server/Chart.yaml b/charts/mlflow-server/Chart.yaml
@@ -8,7 +8,7 @@ sources:
   - https://github.com/strangiato/helm-charts/tree/main/charts/mlflow-server
   - https://github.com/strangiato/mlflow-server
 
-version: 0.6.3
+version: 0.6.4
 appVersion: "2.10"
 
 icon: https://avatars.githubusercontent.com/u/39938107

diff --git a/charts/mlflow-server/templates/deployment.yaml b/charts/mlflow-server/templates/deployment.yaml
@@ -84,8 +84,10 @@ spec:
                   name: {{ include "mlflow-server.fullname" . }}
                   key: S3_ENDPOINT_URL
             {{ end }}
+            {{ if .Values.objectStorage.caBundle }}
             - name: AWS_CA_BUNDLE
-              value: /run/secrets/kubernetes.io/serviceaccount/service-ca.crt
+              value: .Values.objectStorage.caBundle
+            {{ end }}
             {{ if .Values.crunchyPostgres.enabled }}
             - name: PGBOUNCE_HOST
               valueFrom:

diff --git a/charts/mlflow-server/values.yaml b/charts/mlflow-server/values.yaml
@@ -75,6 +75,8 @@ objectStorage:
   s3AccessKeyId: ""
   # -- S3 Secret Access Key if the objectBucketClaim is disabled
   s3SecretAccessKey: ""
+  # -- The CA bundle for the internal cluster certs.  Set this value to "" for AWS S3.
+  caBundle: /run/secrets/kubernetes.io/serviceaccount/service-ca.crt
 
 crunchyPostgres:
   # -- Enable creation of a postgres instance using crunchyPostgres operator