Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade remark-gfm from 4.0.0 to 3.0.1 to render markdown tables #924

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

snehankekre
Copy link
Contributor

📚 Context

#906 upgraded all of the docs' dependencies. An upgraded plugin (remark-gfm) contains an open bug that breaks table rendering. See:

  1. Breaks with latest version of remark-gfm; unhelpful error message hashicorp/next-mdx-remote#403
  2. fix: add remark-gfm nodejs/nodejs.org#5978
  3. https://stackoverflow.com/questions/77138105/reactmarkdown-remarkgfm-everything-renders-as-expected-except-tables-typee

Until the issue is patched upstream in next-mdx-remote, the temporary solution (as nodejs has done) is to downgrade to version 3.0.1.

🧠 Description of Changes

  • Downgrades remark-gfm from 4.0.0 to 3.0.1 to render markdown tables

Revised:

image

Current:

image

💥 Impact

Size:

  • Small
  • Not small

🌐 References

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-dmatthews sfc-gh-dmatthews merged commit 3a1b70a into main Jan 10, 2024
4 checks passed
@sfc-gh-dmatthews sfc-gh-dmatthews deleted the fix/918 branch January 10, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table rendering in markdown appears to be broken
2 participants