-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][Proposal-2] Support including the topic name to the metadata(#836) #862
Conversation
@RobertIndie:Thanks for your contribution. For this PR, do we need to update docs? |
@RobertIndie:Thanks for providing doc info! |
@RobertIndie:Thanks for your contribution. For this PR, do we need to update docs? |
### Motivation Add doc for #862
) (#862) ### Motivation Currently, we don't include the topic name to the metadata. And there is not intuitive workaround for it. This proposal introduces a new configuration `includeTopicName` to the Cloud Storage sink connector. When activated(`true`), the connector will include the topic name to the metadata in the sink file. ### Modifications Introduce a new configuration `includeTopicToMetadata` to support including the Pulsar topic name into the metadata. The new data format of the cloud storage format would be like: ```json { "key": "value", "__message_metadata__": { "messageId": "CAgQADAA", "topic": "persistent://public/default/test-s3", "properties": {} } } ``` A new key, `topic`, would be added to the metadata, containing the Pulsar topic name. (cherry picked from commit b2b28dd)
Proposal link: #860
Special release for #816
See #816
includeTopicToMetadata
(cherry picked from commit 94620e4)
Motivation
Currently, we don't include the topic name to the metadata. And there is not intuitive workaround for it.
This proposal introduces a new configuration
includeTopicName
to the Cloud Storage sink connector. Whenactivated(
true
), the connector will include the topic name to the metadata in the sink file.Modifications
Introduce a new configuration
includeTopicToMetadata
to support including the Pulsar topic name into the metadata.The new data format of the cloud storage format would be like:
A new key,
topic
, would be added to the metadata, containing the Pulsar topic name.Tests
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)