Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forward ordering key #294

Closed
wants to merge 3 commits into from
Closed

forward ordering key #294

wants to merge 3 commits into from

Conversation

stellit
Copy link
Contributor

@stellit stellit commented Aug 29, 2023

forward ordering key while preparing the message

BewareMyPower
BewareMyPower reviewed Sep 11, 2023
View reviewed changes
Copy link

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to protect this change?

IIRC, without this patch, the message received from the consumer won't have the ordering key that was set by the producer side.

@BewareMyPower
Copy link

Close it due to long inactivity time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BewareMyPower BewareMyPower BewareMyPower left review comments

@tisonkun tisonkun Awaiting requested review from tisonkun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stellit @BewareMyPower @tisonkun