-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade terraform-google-kubernetes-engine module to 29.0.0 #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to expose deletion_protection
, it need to be configured before destroy.
https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/b6f35606ab373d5f572ff873569aeee5e5bf7f32/cluster.tf#L34 |
@mitch-hamm Could you verify if the breaking changes introduced in v30.x will affect us? if not we should be good to upgrade to latest version so we can benefit. |
Unfortunately they will affect us. It's some breaking changes with that version we can clear up in a follow PR though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend: change the PR title to Upgrade terraform-google-kubernetes-engine module to 29.0.0
Update terraform-google-modules/kubernetes-engine to 29.0.0 which is the latest version without major breaking changes