Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade terraform-google-kubernetes-engine module to 29.0.0 #34

Merged
merged 8 commits into from
Apr 15, 2024

Conversation

mitch-hamm
Copy link
Contributor

@mitch-hamm mitch-hamm commented Mar 8, 2024

Update terraform-google-modules/kubernetes-engine to 29.0.0 which is the latest version without major breaking changes

@mitch-hamm mitch-hamm requested a review from a team as a code owner March 8, 2024 16:08
@mitch-hamm mitch-hamm changed the title Update kubernetes engine to latest version fix: Update kubernetes engine to latest version Mar 8, 2024
Copy link
Member

@ciiiii ciiiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxsxu maxsxu changed the title fix: Update kubernetes engine to latest version feat: Update kubernetes engine to latest version Mar 12, 2024
@mitch-hamm
Copy link
Contributor Author

@mitch-hamm mitch-hamm requested review from ciiiii and maxsxu March 25, 2024 16:07
@maxsxu
Copy link
Member

maxsxu commented Mar 26, 2024

Update terraform-google-modules/kubernetes-engine to 29.0.0 which is the latest version without major breaking changes

@mitch-hamm Could you verify if the breaking changes introduced in v30.x will affect us? if not we should be good to upgrade to latest version so we can benefit.

@mitch-hamm
Copy link
Contributor Author

Update terraform-google-modules/kubernetes-engine to 29.0.0 which is the latest version without major breaking changes

@mitch-hamm Could you verify if the breaking changes introduced in v30.x will affect us? if not we should be good to upgrade to latest version so we can benefit.

Unfortunately they will affect us. It's some breaking changes with that version we can clear up in a follow PR though

Copy link
Member

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend: change the PR title to Upgrade terraform-google-kubernetes-engine module to 29.0.0

@mitch-hamm mitch-hamm changed the title feat: Update kubernetes engine to latest version feat: Upgrade terraform-google-kubernetes-engine module to 29.0.0 Apr 15, 2024
@mitch-hamm mitch-hamm merged commit 411d32d into master Apr 15, 2024
5 checks passed
@mitch-hamm mitch-hamm deleted the mh/33 branch April 15, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants