Use WaitGroup to ensure suite.Run() doesn't exit until all tests are done #1447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a
WaitGroup
tosuite
'sRun
function to better support parallel testsChanges
WaitGroup
insuite
'sRun
functionWaitGroup
for each test in the suitedefer wg.Done()
as the very last defer of each test to appropriately mark it as donewg.Wait()
before returning fromRun
to ensure thatRun
'sdefer
statement are only executed after all tests have completedMotivation
When using a suite with multiple tests that are defined as parallel tests (
t.Parallel()
called), the suite's stats reporting is inaccurate because theWithStats
method is called from adefer
in theRun
method, which exits before all tests have completed.Related issues