mock: caller information for unexpected method call #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brackendawson
requested changes
Sep 30, 2024
There was a problem hiding this comment.
This makes sense as an addition, especially given the else case already does it.
Can you update a test too please? Possibly TestArgumentMatcherToPrintMismatch but maybe something else. Confirming that the test's own file base name is in the stack should be sufficient.
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using mocks in large integration tests, it is very difficult to find places of unexpected function calls.
Changes
I suggest adding information about the location of the call.
Motivation
Related issues