-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system test] Auto-rebalance feature test case #10666
base: main
Are you sure you want to change the base?
Conversation
development-docs/systemtests/io.strimzi.systemtest.cruisecontrol.CruiseControlST.md
Outdated
Show resolved
Hide resolved
development-docs/systemtests/io.strimzi.systemtest.cruisecontrol.CruiseControlST.md
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/utils/kafkaUtils/KafkaUtils.java
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/utils/kafkaUtils/KafkaUtils.java
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/utils/kafkaUtils/KafkaUtils.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/cruisecontrol/CruiseControlST.java
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/cruisecontrol/CruiseControlST.java
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/cruisecontrol/CruiseControlST.java
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/cruisecontrol/CruiseControlST.java
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/cruisecontrol/CruiseControlST.java
Show resolved
Hide resolved
73c260d
to
8325741
Compare
systemtest/src/main/java/io/strimzi/systemtest/utils/kafkaUtils/KafkaUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, thanks :)
systemtest/src/main/java/io/strimzi/systemtest/utils/kafkaUtils/KafkaRebalanceUtils.java
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/utils/kafkaUtils/KafkaUtils.java
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/systemtest/utils/kafkaUtils/KafkaUtils.java
Outdated
Show resolved
Hide resolved
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
development-docs/systemtests/io.strimzi.systemtest.cruisecontrol.CruiseControlST.md
Show resolved
Hide resolved
development-docs/systemtests/io.strimzi.systemtest.cruisecontrol.CruiseControlST.md
Outdated
Show resolved
Hide resolved
@Step(value = "Check that topic replicas are moved to the new brokers.", expected = "Topic replicas are distributed onto the newly added brokers."), | ||
@Step(value = "Scale Kafka down to the original number of brokers.", expected = "Kafka brokers are scaled down, and Cruise Control initiates rebalancing in REMOVE_BROKERS mode."), | ||
@Step(value = "Verify that Kafka auto-rebalance status transitions to RebalanceOnScaleDown and then back to Idle.", expected = "Auto-rebalance status moves to RebalanceOnScaleDown during scaling down and returns to Idle after rebalancing completes."), | ||
@Step(value = "Confirm that the cluster is stable after scaling operations.", expected = "Cluster returns to a stable state with initial number of brokers and Cruise Control completed the rebalancing.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@see-quick see the comments I made on the description, they apply here as well.
Converting to the draft I have faced issue [1] multiple times (3/5 times race conditions happen). [1] - #10631 |
dc81cd2
to
d66e6a6
Compare
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
Signed-off-by: see-quick <[email protected]>
d66e6a6
to
5ccc96a
Compare
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
@see-quick build and regression are green, I guess we can move this back as ready to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@im-konge can you have another pass on this please? |
Type of change
Description
This PR adds a system test to cover the basic functionality of the auto-balance feature.
Checklist