Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use valid label values in KafkaST tests #10708

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Oct 12, 2024

Type of change

  • Bugfix

Description

For some reason, the labels test in KafkaST seems to be using label values with . at the end which seems to be invalid. This PR tries to fix it to make the tests pass again.

@see-quick Not sure if this change in #10650 was intentional or just some replace-all mistake ... it seems like the second case to me.

Checklist

  • Make sure all tests pass

@scholzj scholzj added this to the 0.44.0 milestone Oct 12, 2024
@scholzj scholzj requested review from see-quick and a team October 12, 2024 13:10
@scholzj
Copy link
Member Author

scholzj commented Oct 12, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I don't know how I could missed it during the review 🤦

@scholzj scholzj merged commit c7bb75c into strimzi:main Oct 12, 2024
21 checks passed
@scholzj scholzj deleted the use-valid-label-values-in-KafkaST branch October 12, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants