[ST] Remove line for setting null for LMFV in StrimziDowngradeST #10709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Kral <[email protected]>
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR removes line that sets
nullas a version for LMFV. In the examples, we are not setting it and we are leavingthis on the operator. And initially when I wrote the test, I thought that we are using the examples during the test (during initial deployment of Kafka). However, because we are downgrading from the
HEAD, we are applying our own Kafka builder, which anyway sets the LMFV.After this PR is merged, it should fix the version mismatch during the downgrade tests.
Checklist