Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Canary install files from the packaging folder #10734

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

im-konge
Copy link
Member

Type of change

  • Removal

Description

This PR removes the Canary installation files from the packaging folder, as agreed in proposal - 86 - Archive Canary project.
The installation files from the install folder will be removed as part of the next Strimzi release.
This also removes the step from the Makefile to copy the Canary install files to the release folder.

Checklist

  • Update install files

@im-konge im-konge requested a review from a team October 18, 2024 12:42
@im-konge im-konge self-assigned this Oct 18, 2024
@im-konge im-konge added this to the 0.44.0 milestone Oct 18, 2024
@im-konge
Copy link
Member Author

@PaulRMellor should I do something to remove it from the docs? Or will that be removed as part of the next Strimzi release? I saw some mentions in the deploying and overview folders of the documentation folder

@scholzj
Copy link
Member

scholzj commented Oct 18, 2024

@PaulRMellor should I do something to remove it from the docs? Or will that be removed as part of the next Strimzi release? I saw some mentions in the deploying and overview folders of the documentation folder

There is no such update to the docs as part of the release. So you need to do it here.

@im-konge
Copy link
Member Author

@PaulRMellor should I do something to remove it from the docs? Or will that be removed as part of the next Strimzi release? I saw some mentions in the deploying and overview folders of the documentation folder

There is no such update to the docs as part of the release. So you need to do it here.

Cool, thanks for info :) will do it here.

@im-konge
Copy link
Member Author

So the installation files are just linked in the documentation, it should be fine just with removing it from the packaging/install

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add also a note to CHANGELOG to the removals section?

@im-konge
Copy link
Member Author

Good point -> I added a line to the Changes, deprecations and removals section, mentioning the proposal and that the project was archived. Thanks @scholzj

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Jakub Scholz <[email protected]>
Signed-off-by: Lukáš Král <[email protected]>
@scholzj scholzj merged commit 15533e3 into strimzi:main Oct 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants