Some fixes #243
Merged
Some fixes #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to reset the `r_sent` flag in case we drop the `<r>` stanza, otherwise the SM `h` request mechanism stops working. Signed-off-by: Steffen Jaeckel <[email protected]>
In case we're in disconnected state, allow the user to drop the first element of the send queue, even if it was already in progress to be written. Before this patch, the first element could not be retrieved at all, even after a disconnect. Signed-off-by: Steffen Jaeckel <[email protected]>
This was reported as creating a segfault in [0] [0] profanity-im/profanity#1963 Signed-off-by: Steffen Jaeckel <[email protected]>
GnuTLS has support already built-in. Signed-off-by: Steffen Jaeckel <[email protected]>
Patch written by @matthias-hmb This fixes #241 Signed-off-by: Steffen Jaeckel <[email protected]>
sjaeckel
force-pushed
the
some-fixes
branch
6 times, most recently
from
88edffe
to
1e6637e
Compare
Signed-off-by: Steffen Jaeckel <[email protected]>
Building the SSL library is too much overhead, let's do this only once and re-build and run libstrophe with Valgrind enabled in the same runner. Signed-off-by: Steffen Jaeckel <[email protected]>
Make sure to use the custom built TLS library. Signed-off-by: Steffen Jaeckel <[email protected]>
* be a bit more verbose on `getaddrinfo()` error * fix missing space Signed-off-by: Steffen Jaeckel <[email protected]>
Unfortunately OpenSSL didn't implement a warning for deprecated macros, so this wasn't discovered until now. Discovered in [0]. OpenSSL patch to improve the situation proposed in [1]. [0] #244 [1] openssl/openssl#24296 Signed-off-by: Steffen Jaeckel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check commit messages for details