Keep Firefox window from scrolling right in presentations #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey in presentations.
|
LGTM, 👍 to merge. |
| .mainPresentation #presentation { | ||
| display: block; | ||
| .mainPresentation { | ||
| position: fixed; |
There was a problem hiding this comment.
I am not sure this is a good idea. Please explain why exactly this is required and why the mainPresentation needs to be fixed to prevent something from scrolling in Firefox?
There was a problem hiding this comment.
In Firefox the window scrolls right when paging the presentation with the right key. It slides the window over to reveal the hidden buddyList along with triggering a page right. This fixes the window so the window cannot scroll right.
|
Closing to base off develop. See new PR #153. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix FS#1934: Presentation mode - right arrow key scrolls window with presentations slides in Firefox on Mac.