fix: Improve reliability of embedded resources resolving #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er.cs, removed conditional compilation. First it tries to resolve the .NET core way, if that doesn't work it proceeds with the .NET framework way. EmbeddedResourcesGenerator.cs now passes the added CustomAssemblyResolver to LoadModule call to override the default resolving behavior. This object is re-created for each call, maybe it can be instantiated once? Not sure what the lifecycle should be.
src/Stryker.Core/Stryker.Core/Initialisation/CrossPlatformAssemblyResolver.cs
Outdated
Show resolved
Hide resolved
src/Stryker.Core/Stryker.Core/Initialisation/CrossPlatformAssemblyResolver.cs
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
|
@FrankvdStam This fix has been released in 0.22.4. Please go ahead and test if this works for your case :) |
|
I'll try but it'll be a while. Thanks anyway :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1501
Supersedes #1502
@FrankvdStam I tested and cleaned up the PR. Looks good to me! I noticed you branched off of v1 but since this is a fix it can go straight to master. I created a new branch to fix this and cherry-picked your fixes onto it.