-
Notifications
You must be signed in to change notification settings - Fork 53
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
bc477ee
commit ddb6f40
Showing
1 changed file
with
5 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddb6f40
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In dev mode Chrome shows an error for this key. This isn't visible in normal mode though and doesn't influence the functionality but I'm quite sure we'll have quite a few "bug" reports on that in the future.
I guess it can be solved with a build script: the main manifest won't contain this key, there will be a manifest.firefox.json (or firefox/manifest-additions.json) with just this key, the build script will insert it into the main manifest and put it into a folder named build or firefox or whatever.