-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support client config with tcp_port
but without command
#2300
support client config with tcp_port
but without command
#2300
Conversation
We should mention this new behavior in documentation (in the docs folder). Currently it states that we start the server - https://lsp.sublimetext.io/client_configuration/#tcp-localhost-subprocess-acts-as-a-tcp-server |
tcp_port
but without command
Thanks for detailed feedback, tried to fix it all, the way I pass the stderr argument to the constructor looks filthy but no idea what is correct form to do this so I just kept it simple and ugly. |
the linter stuff should be fixed, no idea what the macos error is about edit: also, should we update the gdscript server setup howto in the docs to command-less version ? Or mention it there as an fix for the specific issue I was having |
thanks for putting up with my mess, do you use any specific stuff for the formatting? black? or am i missing something in the pylsp/pyright that i have in sublime. |
I'm just following the conventions that we have in this code base and the changes were all manual. |
#2214
I have no idea if this is too hacky to be pulled, or what it breaks. It does work for my usecase tho. Would be cool if it doesn't find a server, it would just wait until one shows up instead of disabling the lsp until manually enabled again. Maybe i'll do it if I find it annoying enough.
If there would be small edits needed to be pulled I can totally do them, if there are fundamental issues I probably wont bother.