Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support client config with tcp_port but without command #2300

Merged
merged 13 commits into from
Aug 15, 2023

Conversation

weckr
Copy link
Contributor

@weckr weckr commented Jul 16, 2023

#2214

I have no idea if this is too hacky to be pulled, or what it breaks. It does work for my usecase tho. Would be cool if it doesn't find a server, it would just wait until one shows up instead of disabling the lsp until manually enabled again. Maybe i'll do it if I find it annoying enough.

If there would be small edits needed to be pulled I can totally do them, if there are fundamental issues I probably wont bother.

@rchl
Copy link
Member

rchl commented Aug 2, 2023

We should mention this new behavior in documentation (in the docs folder). Currently it states that we start the server - https://lsp.sublimetext.io/client_configuration/#tcp-localhost-subprocess-acts-as-a-tcp-server

plugin/core/transports.py Outdated Show resolved Hide resolved
plugin/core/transports.py Show resolved Hide resolved
plugin/core/transports.py Outdated Show resolved Hide resolved
plugin/core/transports.py Outdated Show resolved Hide resolved
@rchl rchl changed the title working lsp over tcp when user provides a port but doesnt provide any lsp launch command support client config with tcp_port but without command Aug 2, 2023
@weckr
Copy link
Contributor Author

weckr commented Aug 3, 2023

Thanks for detailed feedback, tried to fix it all, the way I pass the stderr argument to the constructor looks filthy but no idea what is correct form to do this so I just kept it simple and ugly.

@weckr
Copy link
Contributor Author

weckr commented Aug 4, 2023

the linter stuff should be fixed, no idea what the macos error is about

edit: also, should we update the gdscript server setup howto in the docs to command-less version ? Or mention it there as an fix for the specific issue I was having

@rchl rchl merged commit eac7700 into sublimelsp:main Aug 15, 2023
4 checks passed
@weckr
Copy link
Contributor Author

weckr commented Aug 15, 2023

thanks for putting up with my mess, do you use any specific stuff for the formatting? black? or am i missing something in the pylsp/pyright that i have in sublime.

@rchl
Copy link
Member

rchl commented Aug 15, 2023

I'm just following the conventions that we have in this code base and the changes were all manual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants