Add python 3.8

[predragnikolic]

related #2417
PLEASE DO NOT MERGE.

[predragnikolic]

I am not sure how to address the CI error:

Traceback (most recent call last):
  File "./python3.8/unittest/loader.py", line 436, in _find_test_path
  File "./python3.8/unittest/loader.py", line 377, in _get_module_from_name
  File "/Users/runner/Library/Application Support/Sublime Text/Packages/LSP/tests/test_message_request_handler.py", line 2, in <module>
    from test_mocks import MockSession
  File "/Users/runner/Library/Application Support/Sublime Text/Packages/LSP/tests/test_mocks.py", line 5, in <module>
    from LSP.plugin.core.types import ClientConfig
  File "/Users/runner/Library/Application Support/Sublime Text/Packages/LSP/plugin/core/types.py", line 9, in <module>
    from wcmatch.glob import BRACE
ModuleNotFoundError: No module named 'wcmatch.glob'

[rchl]

Unittesting runs on PC3 I guess

[rwols]

wcmatch is a dependency that’s only available for py33.

[predragnikolic]

wcmatch is a dependency that’s only available for py33.

It supports 3.8 ->
https://github.com/packagecontrol/channel/blob/8142a3b67d2ee640d8769cbfcec593e6e4df5554/repository.json#L1371

[rchl]

And as far as I understand only PC4 can understand that new schema.

[rwols]

Not minding the spam at all. In fact you’re doing some great work 👍

[deathaxe]

Changing the setting in view.settings().set("lsp_uri", "file:///foo/bar.txt") to something else (e.g.: view.settings().set("lsp_uri_2", "file:///foo/bar.txt") causes 1 or 2 tests to fail, but none gets stuck.

The problem seems to be related with the settings change listeners used by WindowConfigManager, which seem to lock up something.

I've recently saw comparable issues with conditions timing out on UnitTestings test cases itself every here and then on all OSs. They seem to have been related with test packages being created and removed for each test method individually. Creating and cleaning up all packages for each TestCase at once, fixed the issue. see: https://github.com/SublimeText/UnitTesting/pull/244/files

UnitTesting uses sublime.set_timeout() to schedule tests. Everytime a test method yields, another set_timeout() call is made to enqueue further steps, while giving core time to handle events.

Maybe we hit some limits of how many events/messages can be handled.

[deathaxe]

Seems to be a missing view instance, causing it. Using ViewTestCase fixes the issue.

see: https://github.com/deathaxe/LSP/actions/runs/8403796385/job/23014682385

https://github.com/deathaxe/LSP/blob/adf5f79a28fea3ede3bceb7cf5146a08d2b57c87/tests/test_configurations.py#L29

[predragnikolic]

Just to document.

CI was fixed with #2436 (comment)
by using a ViewTestCase:

ViewTestCase ...

• provides view and window members pointing to a dedicated view, being created for testing.
• ensures not to close empty windows, which was probably the most likely reason for unittests failing before on MacOS.

[predragnikolic]

I also plan to add a release message.

[rwols]

Now it’s a safe next step to announce some kind of deadline date to do the transition to py38 for all helper packages with this ready to merge :)

[rchl]

Would include info on how this affects users.

I guess the most apparent side effect is that ST will require an extra restart for things to start working properly. Maybe the original warning should be updated to reflect that since for this case it will behave differently than normally.

[predragnikolic]

How about this?

⚠️ After updating the LSP package, Sublime Text will need to be restarted more than once for things to work properly. ⚠️

# Breaking changes
- We are transitioning LSP and LSP-* packages from Python 3.3 to Python 3.8.

[predragnikolic]

I did expand the release message to include info about what the user can expect in this update
and what the user can do if problem arise during the update.

[predragnikolic]

b8d867c