Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure didChange notification is never sent after didClose #2438

Merged
merged 15 commits into from
Apr 20, 2024
Merged

Ensure didChange notification is never sent after didClose #2438

merged 15 commits into from
Apr 20, 2024

Commits on Mar 26, 2024

  1. Ensure didChange is never sent after didClose 

    This fixes for example the Pyright warning
LSP-pyright: Received change text document command for closed file <URI>
when a file is saved and closed immediately after changes were applied.
    @jwortmann
    jwortmann committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    9c9493a View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Missed something

    @jwortmann
    jwortmann committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    ba364a7 View commit details
    Browse the repository at this point in the history

  2. Add test

    @jwortmann
    jwortmann committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    c211f99 View commit details
    Browse the repository at this point in the history

  3. Maybe like this?

    @jwortmann
    jwortmann committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    b8b0d9b View commit details
    Browse the repository at this point in the history

  4. Try something else

    @jwortmann
    jwortmann committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    d430b9f View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Simplify expression to save one unnecessary API call 

    view.change_count() returns 0 if the view isn't valid anymore (closed),
so we can simply use short-circuit evaluation for this and don't need
the is_valid() API call.
    @jwortmann
    jwortmann committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    0fc0e1e View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Exempt Linux

    @jwortmann
    jwortmann committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    4dd2e91 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. Small tweak to save an API call

    @jwortmann
    jwortmann committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    aca100e View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Revert "Exempt Linux" 

    This reverts commit 4dd2e91.
    @jwortmann
    jwortmann committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    740c0cb View commit details
    Browse the repository at this point in the history

  2. Fix failing test on Linux

    @jwortmann
    jwortmann committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    dd66a6a View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. actually this test passes locally with this line uncommented

    @predragnikolic
    predragnikolic committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    43ede82 View commit details
    Browse the repository at this point in the history

  2. Revert, apparently it fails on the CI... 

    This reverts commit 43ede82.
    @predragnikolic
    predragnikolic committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b5ee72e View commit details
    Browse the repository at this point in the history

  3. try a slightly different approach just to see... test pass locally

    @predragnikolic
    predragnikolic committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    11c5ecb View commit details
    Browse the repository at this point in the history

  4. Revert "try a slightly different approach just to see... test pass lo… 

    …cally"

the test still fail on the CI

This reverts commit 11c5ecb.
    @predragnikolic
    predragnikolic committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2b5f56f View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Merge branch 'main' into fix-notification-order

    @jwortmann
    jwortmann committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    11e3455 View commit details
    Browse the repository at this point in the history