Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check semantic capability through session buffer #2453

Merged
merged 3 commits into from
Apr 20, 2024

Conversation

rchl
Copy link
Member

@rchl rchl commented Apr 19, 2024

It's always more correct to first check capability through session buffer in case server registers capability dynamically with a selector.

Resolves #2452

Copy link
Member

@jwortmann jwortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like I missed this one when I fixed a few others in #2222

@predragnikolic predragnikolic merged commit 4f30db8 into main Apr 20, 2024
8 checks passed
@predragnikolic predragnikolic deleted the fix/semantic-diagnostics-capability branch April 20, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capabilites with selector fails to register
3 participants