Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logging.basicConfig() #2478

Merged
merged 4 commits into from
May 29, 2024
Merged

Remove logging.basicConfig() #2478

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60e1768
remove logging.basicConfig()
predragnikolic May 20, 2024
17ae252
Revert "remove logging.basicConfig()"
predragnikolic May 29, 2024
d9b49b0
Merge branch 'main' into avoid-polluting-other-plugins
predragnikolic May 29, 2024
b6bd450
add comments
predragnikolic May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion third_party/websocket_server/websocket_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
from socketserver import ThreadingMixIn, TCPServer, StreamRequestHandler

logger = logging.getLogger(__name__)
logging.basicConfig()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment it out and add a comment that explains the reasoning in case we end at one point end up updating this dependency, so that we know why it was removed.

# This line installed a root logger, which results in duplicate log entries.
# For more details, see: https://github.com/sublimelsp/LSP/issues/2477
# logging.basicConfig()

'''
+-+-+-+-+-------+-+-------------+-------------------------------+
Expand Down