-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Truncate inlay hint label #2514
Merged
Merged
Changes from 33 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
1d85bcc
Truncate inlay hint label
bivashy 41150db
Split long line into multiple lines
bivashy 0c9f49c
Add `inlay_truncate_limit` into settings
bivashy 9755ed2
Add `inlay_truncate_limit` into sublime package
bivashy 5c86172
Fix missing ellipsis at specific cases
bivashy 528a430
Rename property `inlay_truncate_limit` into `inlay_hints_truncate_limit`
bivashy 6335b74
Do not modify method variable, use local variable instead
bivashy 8265c1b
Make sure that truncation limit is exclusive
bivashy c43d722
Split long line into multiple lines
bivashy a882902
Replace three dots with a compact character
bivashy 808e817
Inlay hint tooltip implementation
bivashy 1ba72a6
Read from user preference directly
bivashy 1c313b5
Show truncation tooltip if label is raw string
bivashy 25be2dd
Merge branch 'main' into main
bivashy c618857
Fix typo
bivashy cc4ad00
Merge remote-tracking branch 'origin/main'
bivashy 08b9795
Remove truncate_limit parameter
bivashy 9f0f3c7
Use ternary operator instead of plain if else
bivashy 1a09aa5
Fix flake8 formatting
bivashy 1a5bae4
Remove redundant blank line
bivashy 0fcdf79
Properly show truncation tooltip
bivashy bc41741
Remove redundant newline in truncation tooltip
bivashy abe0987
Inclusive truncate limit
bivashy 17591c1
Change default truncate limit to `100`
bivashy 09162a2
Support negative, or zero truncate limit
bivashy 79fee60
Merge branch 'main' into main
bivashy 19a991a
Merge branch 'main' into main
bivashy 0496789
Rename `inlay_hints_truncate_limit` into `inlay_hints_max_length`
bivashy c6e0055
Append truncation tooltip instead of wrapping result
bivashy e5b9050
Merge branch 'main' into main
bivashy c4c74cc
Merge branch 'main' into main
bivashy b83a147
Remove empty lines
bivashy 9be92d9
Change truncation limit to exclusive one.
bivashy dc7d5ca
Match `sublime-package.json` with settings description
bivashy 87db8f3
Merge branch 'main' into main
bivashy d6a544a
Change truncation limit to exclusive
bivashy 0a4a246
Merge branch 'main' into main
bivashy a43e68a
Lower the limit of the inlay hint
bivashy 875a7a0
Merge branch 'main' into main
bivashy 572b1cd
Specify missing truncation case in description
bivashy b039ea8
Tweak setting description
jwortmann 8e86dc3
Merge branch 'main' into main
bivashy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also be
>
here or not?I have tested the PR with a server that uses the regular label (no label parts) and I think it works well with the tooltips.
My only suggestion left would be to use a lower default value for the setting. I think 30 would be a sane default. I would say the truncation is actually a good thing to do, and some users might not check settings or read update notes, so it should be applied by default. Opinions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check it out. Thanks for pointing that out.
I think inlay hint is not enabled by default, so most users will not be affected. So I agree that this feature should be enabled by default. I'll wait for more opinions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in d6a544a.
Done in a43e68a
I will not resolve this conversation in case of reconsideration, should I?