sophora-admin-dashboard: Don't render annotations for Service if em…

…pty (#90) * sophora-admin-dashboard: Don't render `annotations` for Service if empty * remove manual line break --------- Co-authored-by: Philip Dakowitz <[email protected]>
subshell · May 7, 2024 · 7d2dc7e · 7d2dc7e
1 parent 401bb2d
commit 7d2dc7e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/charts/sophora-admin-dashboard/Chart.yaml b/charts/sophora-admin-dashboard/Chart.yaml
@@ -9,4 +9,4 @@ maintainers:
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 1.2.0
+version: 1.2.1
diff --git a/charts/sophora-admin-dashboard/templates/service.yaml b/charts/sophora-admin-dashboard/templates/service.yaml
@@ -4,7 +4,9 @@ metadata:
   name: {{ include "sophora-admin-dashboard.fullname" . }}
   labels:
     {{- include "sophora-admin-dashboard.labels" . | nindent 4 }}
-  annotations: {{- toYaml .Values.service.annotations | nindent 4 }}
+  {{- with .Values.service.annotations }}
+  annotations: {{- toYaml . | nindent 4 }}
+  {{- end }}
 spec:
   type: {{ .Values.service.type }}
   {{ if .Values.service.clusterIP -}}