Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit redis queue renames - prefix with audit and match job class name #2056

Open
4 of 6 tasks
ndushay opened this issue Nov 22, 2022 · 2 comments
Open
4 of 6 tasks
Assignees
Labels
refactor architecture, refactoring, style, etc. tech debt

Comments

@ndushay
Copy link
Contributor

ndushay commented Nov 22, 2022

from storytime 2022-11-21

(Note this is also about matching the redis queue names with the job class name - #2057 - assume no classes will have their names changed as a result of that ticketing, for now.)

  • All audit redis queue names should be prefixed with audit_
    • m2c should become audit_moab_to_catalog
    • c2m should become audit_catalog_to_moab
    • checksum_validation should become audit_checksum_validation
    • Not sure about moab_validation, as it is run by preservation_robot step and isn't really the same sort of audit -- more of a check. @justinlittman is working on understanding whether it is sometimes run as part of other three audits above - maybe ask him?

audit log files

Note that namespacing the audit classes for checking replication is in a separate ticket, #2059

Analogous ticket for replication queues is #2064

@justinlittman
Copy link
Contributor

Please make sure this is coordinated with sidekiq rollout.

@ndushay ndushay changed the title redis queue renames - prefix with audit or replication and match job class name redis queue renames - prefix with audit or and match job class name Nov 22, 2022
@ndushay ndushay changed the title redis queue renames - prefix with audit or and match job class name redis queue renames - prefix with audit and match job class name Nov 22, 2022
@ndushay ndushay changed the title redis queue renames - prefix with audit and match job class name audit redis queue renames - prefix with audit and match job class name Nov 22, 2022
@ndushay
Copy link
Contributor Author

ndushay commented Jan 12, 2023

Now that we're on sidekiq, this also requires updating the worker allocation configs in shared_configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor architecture, refactoring, style, etc. tech debt
Projects
None yet
3 participants