Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replication Job classes - group them in Replication module namespace #2063

Closed
8 of 9 tasks
ndushay opened this issue Nov 22, 2022 · 1 comment · Fixed by #2154
Closed
8 of 9 tasks

Replication Job classes - group them in Replication module namespace #2063

ndushay opened this issue Nov 22, 2022 · 1 comment · Fixed by #2154
Assignees
@ndushay
Labels
refactor architecture, refactoring, style, etc.

Comments

@ndushay
Copy link
Contributor

ndushay commented Nov 22, 2022 •
edited
Loading

from storytime 2022-11-21

Replication job classes should all be in the "Replication" namespace. This includes

  • AbstractDeliveryJob
  • IbmSouthDeliveryJob
  • PlexerJob DeliveryDispatcherJob
  • ResultsRecorderJob
  • S3EastDeliveryJob
  • S3WestDeliveryJob
  • ZipPartJobBase
  • ZipmakerJob

Also, the service classes should correspond:

  • service/s3 should become service/replication

job class names should match queue names in #2064

Note that the replication audit job classes are covered in issue #2059

analogous ticket for audit jobs is #2057
@ndushay ndushay mentioned this issue Nov 22, 2022
Open
6 tasks
@ndushay ndushay added the refactor architecture, refactoring, style, etc. label Nov 22, 2022
This was referenced Nov 22, 2022
Open
Closed
@ndushay
Copy link
Contributor Author

ndushay commented Dec 5, 2022

NOTE: wait for sidekiq to replace redis in production (#1984) before this change is merged to prod!

@ndushay ndushay self-assigned this Dec 16, 2022
This was referenced Jan 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndushay ndushay

Labels
refactor architecture, refactoring, style, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move replication jobs into Replication namespace sul-dlss/preservation_catalog
1 participant
@ndushay