Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new features to the ndcube._add_ method #794
base: main
Are you sure you want to change the base?
Added new features to the ndcube._add_ method #794
Changes from 1 commit
9c38077
1d5d2ab
aaa9ef0
ed4f61e
ea43a1d
a891ff9
f575e2c
8951635
58e4363
bcf4fb9
c4d639a
bd317e3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 926 in ndcube/ndcube.py
Codecov / codecov/patch
ndcube/ndcube.py#L923-L926
Check warning on line 928 in ndcube/ndcube.py
Codecov / codecov/patch
ndcube/ndcube.py#L928
Check warning on line 931 in ndcube/ndcube.py
Codecov / codecov/patch
ndcube/ndcube.py#L931
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition should be done as part of the masked array addition. You've already done this below, you just need to extract the added data from the results as well as the mask.
Check warning on line 935 in ndcube/ndcube.py
Codecov / codecov/patch
ndcube/ndcube.py#L933-L935
Check warning on line 941 in ndcube/ndcube.py
Codecov / codecov/patch
ndcube/ndcube.py#L938-L941
Check warning on line 947 in ndcube/ndcube.py
Codecov / codecov/patch
ndcube/ndcube.py#L944-L947
Check warning on line 950 in ndcube/ndcube.py
Codecov / codecov/patch
ndcube/ndcube.py#L950
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having a separate
return
here for theNDData
case, I think we should build a dictionary ofkwargs
that we can giveself._new_instance
, here. So, you can create an empty kwargs dictionary at the start of the method, and add the new data, uncertainty, etc. in the relevant place, e.g.Then the final line of the method would become
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if this doesn't make sense