-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory consuption in axis_world_coords (again) #798
base: main
Are you sure you want to change the base?
Conversation
If the pixel axes are not correlated with a requested world axis then don't generate the coords in the mesh
This PR needs tests which test at least with some DKIST or IRIS WCSes that you can get low-memory axis world coords for uncorrelated axes, and as a counterpoint that correlated axes still work properly. For example, I have tested that |
I do question why I bother to do any programming if its always wrong. This solution works: Command line: /home/nabil/.mamba/envs/iris-dev/bin/memray run -f -o output.bin examples/umbral_flashes.py The biggest allocations are from loading the data: |
This is great news! |
@nabobalis I can't add a visp WCS without a |
I am the same |
Could we try Wills WCS from his issue? |
This PR works, as an alternative to #780 by not generating mesh coords for unneeded pixel axes.
i.e. if the pixel axes are not correlated with a requested world axis then don't generate the coords in the mesh.