Generalize the RHE Function beyond AIA #231
Conversation
|
This PR is associated with Issue #233 addressing the ability for the algorithm to operate on non-AIA datasets. |
| @@ -221,7 +225,6 @@ def nrgf( | |||
| width_function=np.std, | |||
| width_function_kwargs=None, | |||
| application_radius=1 * u.R_sun, | |||
| progress=True, | |||
There was a problem hiding this comment.
These progress changes will need to be undone.
|
Thanks for the PR @GillySpace27, what other data have were you trying to run this on? We will need to get some test data to confirm it works for non-AIA data. |
|
@nabobalis Thanks! The first non-AIA dataset I applied it to is some synthetic PUNCH test data. I'm interested in getting some others working too, including LASCO, SUVI, etc. |
| new_map.plot_settings["norm"] = None | ||
|
|
||
| # Return the new SunPy map with RHEF applied |
There was a problem hiding this comment.
| # Return the new SunPy map with RHEF applied |
|
|
||
| # Adjust plot settings to remove extra normalization | ||
| # This must be done whenever one is adjusting | ||
| # the overall statistical distribution of values | ||
|
|
sunkit_image/radial.py
Outdated
| data[here] = ranking_func(smap.data[here]) | ||
| if upsilon is not None: | ||
| data[here] = apply_upsilon(data[here], upsilon) | ||
| new_map = sunpy.map.Map(data, meta, autoalign=True) | ||
|
|
||
| # Final update to the map |
There was a problem hiding this comment.
| # Final update to the map |
|
|
||
| # Perform the filtering operation | ||
| ranking_func = _select_rank_method(method) | ||
| # Apply ranking function |
There was a problem hiding this comment.
| # Apply ranking function |
sunkit_image/radial.py
Outdated
| ) | ||
|
|
||
| # Allocate storage for the filtered data |
There was a problem hiding this comment.
| # Allocate storage for the filtered data |
sunkit_image/radial.py
Outdated
| @@ -695,46 +684,57 @@ def rhef( | |||
| https://www.proquest.com/docview/2759080511 | |||
| """ | |||
|
|
|||
| # Get the radii for every pixel | |||
| map_r = find_pixel_radii(smap).to(u.R_sun) | |||
| # Get the radii for every pixel, ensuring units are correct (in terms of pixels or solar radii) | |||
There was a problem hiding this comment.
| # Get the radii for every pixel, ensuring units are correct (in terms of pixels or solar radii) |
| Defaults to True. | ||
| upsilon : float or None, optional | ||
| A double-sided gamma function to apply to modify the equalized histograms. Defaults to 0.35. | ||
| method : str, optional |
There was a problem hiding this comment.
Do we have a list of all the known methods?
There was a problem hiding this comment.
inplace, numpy, and scipy. They are defined above in a helper function. This functionality could probably be removed, but it is nice to have the flexibility I think.
sunkit_image/radial.py
Outdated
| method : str, optional | ||
| Method used to rank the pixels for equalization. Defaults to 'inplace'. | ||
| vignette : `astropy.units.Quantity`, optional | ||
| Radius beyond which pixels will be set to black. Defaults to ``1.5*u.R_sun``. Set to None to disable vignetting. |
There was a problem hiding this comment.
| Radius beyond which pixels will be set to black. Defaults to ``1.5*u.R_sun``. Set to None to disable vignetting. | |
| Radius beyond which pixels will be set to black. Defaults to None, must be in units that are compatible with "R_sun" as the value will be transformed. |
There was a problem hiding this comment.
I'm thinking that setting to NAN is probably more useful since the values aren't valid out there anyway.
There was a problem hiding this comment.
Sure but you won't pass nan to the keyword?
There was a problem hiding this comment.
I'm not sure - are you saying that the default should be a NAN value?
There was a problem hiding this comment.
No, I was just confused.
Is it possible we can add a file from the synthetic PUNCH test data to the repo? |
PR Description