Add autovalidation and remove hardcoded styling from checkboxes #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hardcoded styling for BooleanMetaDataField to prevent it from overriding an app's ThemeData
dshukertjr
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add autoFormValidation to MetaDataField (fixes MetaDataField needs autoValidation to match email/password field functionality #123)
Fixes issue where form could submit with MetaDataField in an invalid state. New behavior matches that of password and email fields.
Remove hardcoded styling for BooleanMetaDataField to prevent it from overriding an app's ThemeData (fixes Remove border outline from BooleanMetaDataField #124)
Fixes issue where border outlines would always appear. New behavior leaves styling up to ThemeData. If users of this library request it, we could potentially add these back as parameters for BooleanMetaDataField to pass down to its child CheckboxListTile, but that doesn't seem necessary for now.