Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make SupaSocialsAuth success SnackBar optional #54

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

brericha
Copy link
Contributor

@brericha brericha commented Jul 8, 2023

What kind of change does this PR introduce?

Feature

What is the current behavior?

After using social auth the package shows a SnackBar with no option to not show it.

What is the new behavior?

Added a bool to SupaSocialsAuth to give the developer the choice to have this SnackBar be shown. The bool is optional and the default value is true, causing no change from the current behavior without the developer setting it to false on their own.

Additionally removed an extra space between the word "in" in the SnackBar message and the ! at the end of the String.

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I love it 🎉

@dshukertjr dshukertjr merged commit 8b9eae1 into supabase-community:main Jul 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants