Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish v0.4.0 #64

Merged
merged 3 commits into from
Jan 3, 2024
Merged

chore: publish v0.4.0 #64

merged 3 commits into from
Jan 3, 2024

Conversation

dshukertjr
Copy link
Member

No description provided.

@dshukertjr dshukertjr marked this pull request as draft January 3, 2024 07:37
@dshukertjr dshukertjr removed the request for review from FatumaA January 3, 2024 07:37
@dshukertjr
Copy link
Member Author

Want to include #65 if possible, so will update this PR if #65 is merged.

@FatumaA
Copy link
Collaborator

FatumaA commented Jan 3, 2024

How are we deciding the version numbers?

@dshukertjr dshukertjr marked this pull request as ready for review January 3, 2024 08:32
@dshukertjr
Copy link
Member Author

@FatumaA
I'm following the semantic versioning. Semantic versioning for v0 is a bit weird for Dart.

You can find the following in Dart package versioning guide

Although semantic versioning doesn’t promise any compatibility between versions prior to 1.0.0, the Dart community convention is to treat those versions semantically as well. The interpretation of each number is just shifted down one slot: going from 0.1.2 to 0.2.0 indicates a breaking change, going to 0.1.3 indicates a new feature, and going to 0.1.2+1 indicates a change that doesn’t affect the public API. For simplicity’s sake, avoid using + after the version reaches 1.0.0.

So for v0, the versioning is 0.major.minor + patch. Since the version of this PR contains a breaking change, I'm incrementing major version and going from 0.3.0 to 0.4.0!

@dshukertjr dshukertjr merged commit 9b52b0e into main Jan 3, 2024
1 check passed
@dshukertjr dshukertjr deleted the chore/publish branch January 3, 2024 09:56
@FatumaA
Copy link
Collaborator

FatumaA commented Jan 3, 2024

__

@FatumaA I'm following the semantic versioning. Semantic versioning for v0 is a bit weird for Dart.

You can find the following in Dart package versioning guide

Although semantic versioning doesn’t promise any compatibility between versions prior to 1.0.0, the Dart community convention is to treat those versions semantically as well. The interpretation of each number is just shifted down one slot: going from 0.1.2 to 0.2.0 indicates a breaking change, going to 0.1.3 indicates a new feature, and going to 0.1.2+1 indicates a change that doesn’t affect the public API. For simplicity’s sake, avoid using + after the version reaches 1.0.0.

So for v0, the versioning is 0.major.minor + patch. Since the version of this PR contains a breaking change, I'm incrementing major version and going from 0.3.0 to 0.4.0!

Thank you! I will read up on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants