Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add native auth support #67

Merged
merged 23 commits into from
Jan 25, 2024
Merged

feat: add native auth support #67

merged 23 commits into from
Jan 25, 2024

Conversation

FatumaA
Copy link
Collaborator

@FatumaA FatumaA commented Jan 8, 2024

What kind of change does this PR introduce?

Add native Google and Apple sign in support
Closes #60

What is the current behavior?

No simple native support

What is the new behavior?

Adds support

@FatumaA FatumaA marked this pull request as draft January 8, 2024 22:16
@FatumaA
Copy link
Collaborator Author

FatumaA commented Jan 8, 2024

Hey @dshukertjr,
This is a first attempt at adding google and apple native auth.
I cant test iOS on my end. The google one seems to work as expected.

Please take a look and also test iOS if poss.

Thank you.

dshukertjr
dshukertjr reviewed Jan 9, 2024
View reviewed changes
text Outdated Show resolved Hide resolved
lib/src/components/supa_socials_auth.dart Show resolved Hide resolved
lib/src/components/supa_native_auth.dart Outdated Show resolved Hide resolved
@FatumaA
Copy link
Collaborator Author

FatumaA commented Jan 22, 2024

Hi @dshukertjr ,
I think this is ready for testing but could do with some clean up.
Have a look and lmk

dshukertjr
dshukertjr reviewed Jan 22, 2024
View reviewed changes
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! I haven't tested it yet, but will do in the morning! Thanks for the amazing work 💪

lib/src/components/supa_socials_auth.dart Outdated Show resolved Hide resolved
lib/src/components/supa_socials_auth.dart Outdated Show resolved Hide resolved
lib/src/components/supa_socials_auth.dart Outdated Show resolved Hide resolved
lib/supabase_auth_ui.dart Outdated Show resolved Hide resolved
@dshukertjr dshukertjr marked this pull request as ready for review January 23, 2024 07:15
dshukertjr
dshukertjr approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, and it works like a charm. Let's merge it whenever you are happy with it!

@FatumaA
Copy link
Collaborator Author

FatumaA commented Jan 25, 2024

I tested it, and it works like a charm. Let's merge it whenever you are happy with it!

I think we can merge then

@dshukertjr dshukertjr merged commit a20501f into supabase-community:main Jan 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshukertjr dshukertjr dshukertjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add native Apple and Google sign in for iOS and Android
2 participants
@FatumaA @dshukertjr