Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofill hints #75

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Add autofill hints #75

merged 3 commits into from
Jan 29, 2024

Conversation

getkey
Copy link
Contributor

@getkey getkey commented Jan 27, 2024

What kind of change does this PR introduce?

Make flutter-auth-ui work well with password managers.

What is the current behavior?

Password managers are unable to pick up the password field.

What is the new behavior?

Password managers can pick up the password field.

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! There is a password field on SupaPhoneAuth widget as well. Would you be able to add it there too?

@getkey
Copy link
Contributor Author

getkey commented Jan 28, 2024

Sure, I also added a couple more I found missing. 🙂

@getkey getkey changed the title Add password autofill hint Add autofill hints Jan 28, 2024
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you so much for this update!

@dshukertjr dshukertjr merged commit e8a9204 into supabase-community:main Jan 29, 2024
1 check passed
@getkey getkey deleted the password-autofill branch January 29, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants