Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autofill not opening when tapping on email field in SupaEmailAuth #80

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

pohuing
Copy link
Contributor

@pohuing pohuing commented Mar 30, 2024

What kind of change does this PR introduce?

Adds an AutofillGroup to the email sign in form

What is the current behavior?

Fixes #79

What is the new behavior?

Activating the email field will now propt for autofill data, selecting an entry from the password field will also fill the email field.

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. So this PR just pretty much wraps the Form with a AutoFillGroup, correct?

It seems like there is a formatting issue, but would you be able to take care of that?

@pohuing
Copy link
Contributor Author

pohuing commented Mar 31, 2024

Thanks for this. So this PR just pretty much wraps the Form with a AutoFillGroup, correct?

exactly.

I'll see if I can figure out what went wrong with the formatting tomorrow. I use dartfmt on save, so maybe our styles are clashing.

@pohuing
Copy link
Contributor Author

pohuing commented Mar 31, 2024

Nothing went wrong as far as I can tell. Since the Form is wrapped in another Widget it's just indented one more layer. Combined with moving the content down one line Github gets very confused detecting changes.

I'll add the same changes to the PhoneAuth Widget as well, since it's the same kind of identifier+password combo

@pohuing
Copy link
Contributor Author

pohuing commented Mar 31, 2024

Nothing went wrong as far as I can tell. Since the Form is wrapped in another Widget it's just indented one more layer. Combined with moving the content down one line Github gets very confused detecting changes.

Ignore this, I didn't even notice the action fail.

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for an amazing update!

@dshukertjr dshukertjr merged commit 45c3fbb into supabase-community:main Apr 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The email sign in autocomplete is not applied to the entire form
2 participants