-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pg_lsp): use tokio, partially remove crossbeam channels #143
Open
juleswritescode
wants to merge
14
commits into
supabase-community:main
Choose a base branch
from
juleswritescode:tokio-async
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor(pg_lsp): use tokio, partially remove crossbeam channels #143
juleswritescode
wants to merge
14
commits into
supabase-community:main
from
juleswritescode:tokio-async
+463
−283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
force-pushed
the
tokio-async
branch
from
October 13, 2024 13:46
20b8567
to
12c86fd
Compare
juleswritescode
commented
Oct 18, 2024
@@ -8,7 +8,6 @@ use super::buffer::{EventBuffer, Get, State}; | |||
struct DebouncerThread<B> { | |||
mutex: Arc<Mutex<B>>, | |||
thread: JoinHandle<()>, | |||
stopped: Arc<AtomicBool>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the linter marked all of this as unused
let cloned_tx = internal_tx.clone(); | ||
let cloned_ide = ide.clone(); | ||
let cloned_pool = pool.clone(); | ||
let pool = Arc::new(threadpool::Builder::new().build()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't dare touch the EventDebouncer
yet 🙈
juleswritescode
changed the title
refactor: tokio main, isolate crossbeam channels
refactor(pg_lsp): use tokio, partially remove crossbeam channels
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
tokio
into thepg_lsp
crate and tries to remove thecrossbeam
dependency from the LspServer.InitializeRequest
flow now lives in its own functionprocess_messages
,handle_message
andhandle_internal_message
client.send_info_message
helper. 🤓Next steps:
lsp_types
with tower_lsp, which should work better with tokioLspClient
and theEventDebouncer
(haven't looked into that yet)Looking forward to your feedback!