-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MailType
as email template parameter
#1451
base: master
Are you sure you want to change the base?
Conversation
lmk if I need to fix the conventional commit thing or if that is fine to do at merge. |
MailType
as email template parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
Can you add some examples to the docs? Or at least here in comments / PR description, so that we can add it in official Supabase docs? |
TODO
Will try add these some time this week 👍 |
Docs PR added, let me know if any of it needs tweaks! |
@hf resolved merge conflicts in this and docs PR |
What kind of change does this PR introduce?
Tiny feature, include the
MailType
in mail template data so that you can build URLs more dynamically. Rely less on strings.What is the current behavior?
Users have to type out magic strings and have to know type manually for each mail type
What is the new behavior?
{{ .MailType }}
can be used in email templatesAdditional context
Introduces const in
template.go
- I know these strings are used elsewhere (verify.go
) but they couldn't be cleanly imported and deal with different concerns. Maybe unifying them is an idea one day.I had to write a different docs PR here so this sort of fixes that: supabase/supabase#21466
TODO?
Likely needs docs update for this section of the Supabase dashboard:
Let me know if you want that PR too, should be easy.