-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add gender, phone, birthdate metadata by kakao provider #1463
base: master
Are you sure you want to change the base?
Conversation
f09b046
to
f5ac224
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @doong-jo, thanks for contributing, can you please add a test the returns the expected values in the mock kakao server for this? you can refer to this section which is where we set up the mock kakao API server
you don't need to write a new test case, modifying the existing successful case to check for the new claims should be sufficient
There are many other options that can be brought in from Kakao Is there a reason to add just these 3? |
( 첨부: 아닙니다! 조금 전에 타일러로부터 검토중이라는 답을 받았습니다! ) |
There is a defined Clams type that encapsulates the structure of user data commonly utilized by providers. This stores metadata provided by the providers. The purpose of this PR is to add missing data within the current structure. To meet your requirements, it seems we would need to separately define the data structure for Kakao or extend the common structure, which is beyond the scope of this PR. It might be more appropriate to address this in a separate PR, subject to further discussion with the maintainer. 안녕하세요 미량님 반갑습니다. 😁 이 PR의 목적은 현재의 구조에서 누락된 데이터를 추가하는 것입니다. 말씀하신 요구사항을 만족하려면 kakao를 위한 데이터 구조를 별도로 정의하거나 공통 구조를 확장해야하는데 그것은 이 PR의 범위를 벗어납니다. 다른 PR에서 작성되어 maintainer와 더 논의가 필요할 것 같습니다. |
@kangmingtay Would you help us? 🥹 |
What kind of change does this PR introduce?
Add KaKaoAcount response to metadata
What is the current behavior?
close #1445
What is the new behavior?
Add gender, phone, birthdate if exists.
Additional context
These data do not always exist and only exist if the user agrees.