Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): update types that are not set on the schema #1848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ffimnsr
Copy link

@ffimnsr ffimnsr commented Nov 27, 2024

What kind of change does this PR introduce?

This changeset updates the migrations schema that's causing trouble on new supabase/auth installations whether it's using docker or not. The types are not set on the schema which causes the migrations to fail. And it adds residual types to public schema.

What is the current behavior?

Issue #1729 was closed despite not resolving the problem.

What is the new behavior?

Add the relevant types to the proper schema.

Additional context

image
image

@ffimnsr ffimnsr requested a review from a team as a code owner November 27, 2024 14:43
This changeset updates the migrations schema that's causing trouble on new
supabase/auth installations whether its using docker or not. The types are not
set on the schema which causes the migrations to fail. And it adds residual
types on public schema.

Signed-off-by: Edward Fitz Abucay <[email protected]>
@ffimnsr
Copy link
Author

ffimnsr commented Nov 27, 2024

It seems the main problem here is the migrator-cmd executes the sql migrations in public schema. That's why when the next sql instruction comes up, it tries to find it in public and that's the reason it fails. That's why I force the schema migrations to use the namespace types.

@patrickwjh
Copy link

patrickwjh commented Dec 11, 2024

Would be nice if this merge request would fix the migration errors. Right now it is not possible for me to start a new docker container because i get always an error that the factor_type doesn't exists.

I can only fix it by manually creating that type in the DB.

So this migration ist the problem in my case: 20240729123726_add_mfa_phone_config.up.sql

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12053898208

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.998%

Totals Coverage Status
Change from base Build 12045179447: 0.0%
Covered Lines: 9546
Relevant Lines: 16748

💛 - Coveralls

@ffimnsr
Copy link
Author

ffimnsr commented Dec 11, 2024

@patrickwjh you might need to create the auth user before doing the migration and set its search path to auth or your custom DB_NAMESPACE.

This PR only solves the problem like if the auth user is not created before doing the migration and that would result in the above screenshots which scatters the types to default schema. A scenario where user will move all created item ownership to auth user afterwards (after running the migration).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants