Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cover 100% of crypto with tests #1892

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: cover 100% of crypto with tests #1892

wants to merge 2 commits into from

Conversation

hf
Copy link
Contributor

@hf hf commented Dec 24, 2024

Covers a 100% of the crypto package with tests.

@hf hf requested a review from a team as a code owner December 24, 2024 17:49
@@ -382,3 +380,26 @@ func (a *API) runHook(r *http.Request, conn *storage.Connection, hookConfig conf

return response, nil
}

func generateSignatures(secrets []string, msgID uuid.UUID, currentTime time.Time, inputPayload []byte) ([]string, error) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this here since it seemed off in crypto.

@coveralls
Copy link

coveralls commented Dec 24, 2024

Pull Request Test Coverage Report for Build 12485140393

Details

  • 83 of 97 (85.57%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 65.436%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/hooks.go 7 21 33.33%
Totals Coverage Status
Change from base Build 12482434145: 0.7%
Covered Lines: 9820
Relevant Lines: 15007

💛 - Coveralls

@hf hf force-pushed the hf/cover-crypto-100 branch 2 times, most recently from b667a3d to 14b0ec5 Compare December 24, 2024 18:24
@hf hf force-pushed the hf/cover-crypto-100 branch from 14b0ec5 to b1a9f64 Compare December 24, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants