chore(types): make types retrocompatible to typescript 4.5.5

[avallete]

What kind of change does this PR introduce?

One of the probable reason causing the number of issues we had with the new inference is probably the use in our tests of typescript ~4.7, in supabase-js we can see the version of typescript is 4.5.5.

This PR is here to reduce the migration friction by allowing the new parser to be retro-compatible with lower typescript version, down to 4.5.5 (I tested down to 4.3.3).

The main change across all was to get rid of the new convenient infer X extends Y syntax only available in typescript 4.7 and higher.

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

[soedirgo]

@avallete can you limit the change to infer X extends Y replacements? There's a bunch of other changes here that seem unrelated (never replacements, Node -> Node['type'], etc.)

[avallete]

@avallete can you limit the change to infer X extends Y replacements? There's a bunch of other changes here that seem unrelated (never replacements, Node -> Node['type'], etc.)

I'll try but:

1. The Node -> Node['type'] change is here because the PR is based over this one where I responded here about why I think it's still necessary.

2. I'll look into the never I mainly did it to ease the reporting and debugging process (it's easier to look for a single unique error string in a specific line than "any never" in the code), and only kept it at place where changing it would have required logic changes somewhere else. But I can revert that and keep the never if you confirm that's what you want those are the places where I have introduced "unrelated never":

https://github.com/supabase/postgrest-js/pull/571/files#diff-5e58fb7db093dc508e6abb63dd5488067ce801a1abbcb5a50644050d106ff1edL174-R179
https://github.com/supabase/postgrest-js/pull/571/files#diff-5e58fb7db093dc508e6abb63dd5488067ce801a1abbcb5a50644050d106ff1edL259-R266

3. Also note that some of the changes notably in the tests is because of downgrading TS to 4.5.5, where function() !== function(undefined) and null narrowing wasn't the same.

[avallete]

Make it consistent with the other FindXXRelationship that return a plain false if no relationship were found instead of never.

[avallete]

This one was actually invalid given the database definition. I added a runtime test for it and adapted the expected error message accordingly.

[avallete]

@soedirgo

I've rebased this one over the correct branch so the diff should be much more focus on the actual changes for 4.5.5 compatibility.

Also reverted some noise with the never replacement / new errors that wasn't necessary to the conversion.

Note that this PR should be merged after the one it base itself of: #569

[github-actions]

🎉 This PR is included in version 1.17.3 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀