Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search result header optimisation #1155

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Search result header optimisation #1155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0896a4a
[NHUB-558] sort by dropdown is below save new topic bar
fritzSF Sep 24, 2024
682f4fb
Merge branch 'develop' of https://github.com/superdesk/newsroom-core …
fritzSF Oct 4, 2024
026555b
[NHUB-562] Checkmark is missing when items are selected for bulk actions
fritzSF Oct 4, 2024
a7c7f99
Merge branch 'develop' of https://github.com/superdesk/newsroom-core …
fritzSF Oct 29, 2024
37e0294
[STTNHUB-371] Newshub Agenda: Some UI elements displayed over filter …
fritzSF Oct 29, 2024
0e6cdb3
Merge branch 'develop' of https://github.com/superdesk/newsroom-core …
fritzSF Nov 6, 2024
0330227
CSS optimisation
fritzSF Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/search/components/SearchResultsBar/SearchResultsAdvancedSearchRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export function SearchResultsAdvancedSearchRow({
secondary={true}
title={gettext('inside')}
>
<div className="toggle-button__group toggle-button__group--spaced toggle-button__group--loose">
<div className="toggle-button__group toggle-button__group--spaced toggle-button__group--compact">
{(Object.keys(fieldNameToLabel) as Array<keyof typeof fieldNameToLabel>)
.filter((fieldName) => availableFields.includes(fieldName))
.map((fieldName) => (
Expand Down
4 changes: 2 additions & 2 deletions assets/styles/agenda.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
gap: 0;
flex-shrink: 0;
display: grid;
grid-template-rows: auto auto 1fr auto;
max-height: clamp(360px, 50svh, 50svh);
grid-template-rows: auto auto auto auto;
max-height: clamp(320px, 50svh, 50svh);
@include phone {
.search-result__tags-list {
border-bottom: 2px solid var(--main-header-color-bg);
Expand Down
11 changes: 8 additions & 3 deletions assets/styles/search-results.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,20 @@
.search-result__tags-list-row {
display: flex;
flex-direction: row;
padding-block: 12px;
padding-block: var(--space--0-5);
gap: var(--space--2);
min-height: 56px;
border-block-start: 1px dashed hsla(0, 0%, 20%, 0.2);
//min-height: 56px;
//border-block-start: 1px dashed hsla(0, 0%, 20%, 0.2);
flex-shrink: 0;
&:first-child {
border: none;
}
&:last-child {
padding-block-end: var(--space--1-5);
}
.tags-list {
flex-grow: 1;
gap: var(--space--0-5);
}
.search-result__tags-list-row-label {
display: inline-flex;
Expand Down Expand Up @@ -121,6 +125,7 @@
z-index: 1;
background-color: var(--search-result-tags-list-color-bg);
box-shadow: inset 0 1px 3px -2px hsla(0, 0%, 0%, 0.2);
padding-block-start: var(--space--1-5);
}
}
.tags-list-row__button-group {
Expand Down
Loading