pls adapt the NINJS outputformatter to provide better references for all renditions [SDCP-723] #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrjasek
reviewed
Nov 14, 2023
petrjasek
reviewed
Nov 16, 2023
petrjasek
reviewed
Nov 16, 2023
petrjasek
reviewed
Nov 16, 2023
petrjasek
approved these changes
Nov 16, 2023
devketanpro
added a commit
to devketanpro/superdesk-core
that referenced
this pull request
Jan 4, 2024
…all renditions [SDCP-723] (superdesk#2489) * udpate renditions settings in NINJS formatter and parser * fix black * add new renditions config * format and populate data based on new config * reformat code via black * refactore rendition parsing * fix pytest * change type * minor change and update tests * fix tests and addressed comment
devketanpro
added a commit
that referenced
this pull request
Jan 4, 2024
…all renditions [SDCP-723] (#2489) (#2506) * udpate renditions settings in NINJS formatter and parser * fix black * add new renditions config * format and populate data based on new config * reformat code via black * refactore rendition parsing * fix pytest * change type * minor change and update tests * fix tests and addressed comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.