Improve multisig performance #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no issues in console, but Send / Propose Tx modal broken and if I'm going into acc details to check Tx or token details wallet will became black screen. 2024-06-25.12.02.09.mov2024-06-25.12.03.20.mov2024-06-25.12.04.09.mov |
CedrikNikita
force-pushed
the
feature/improve-multisig-performance
branch
from
f09bd5c
to
bd0d912
Compare
|
Issue with black screen is remaining: Also no fiat value: |
CedrikNikita
force-pushed
the
feature/improve-multisig-performance
branch
from
bd0d912
to
0eccd65
Compare
|
LGTM |
CedrikNikita
changed the title
peronczyk
requested changes
Jun 27, 2024
peronczyk
reviewed
Jun 27, 2024
CedrikNikita
force-pushed
the
feature/improve-multisig-performance
branch
from
0eccd65
to
a3c13dd
Compare
peronczyk
reviewed
Jun 27, 2024
peronczyk
reviewed
Jun 27, 2024
CedrikNikita
force-pushed
the
feature/improve-multisig-performance
branch
from
a3c13dd
to
7fa405b
Compare
peronczyk
reviewed
Jun 27, 2024
CedrikNikita
force-pushed
the
feature/improve-multisig-performance
branch
from
7fa405b
to
af537dc
Compare
CedrikNikita
force-pushed
the
feature/improve-multisig-performance
branch
from
4743dd5
to
6120f59
Compare
1 similar comment
peronczyk
reviewed
Jun 27, 2024
CedrikNikita
force-pushed
the
feature/improve-multisig-performance
branch
from
999ec29
to
260a033
Compare
CedrikNikita
changed the title
peronczyk
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3092
Idea of this PR is to split all the multisig vaults into array of fives. And only dry-run five vault information in parallel.